Hi, you are right regarding the old-style vs. new-style. I have seen this, but forgot about. I'll fix this with a new patch.
The Kconfig-stuff is indeed only cosmetic, but as is will not break anything I think it's ok. There might be no general rule if all models should be listed or just some examples. It may depend on the number of models for this board and personal mood. I prefer upstreaming working patches, to have others taking advantage of this work more easily. Sven Am Sunday 07 February 2016, 09:00:19 schrieben Sie: > > This looks wrong. You are adding new-style definitions for all revisions > of the WR1043ND without removing the old-style definitions. > > > The Kconfig change is not necessary at all, these strings are never seen > by humans anyways (unless you use kernel_menuconfig or similar). >
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
