Hi Zoltan, thanks for your review!
On Sat, Mar 19, 2016 at 12:53:32PM +0100, Zoltan HERPAI wrote: [..] > > package/boot/uboot-sunxi/Makefile | 8 +++++++- > > > Can you please split this into a series, and put the packages and the > target-related changes into separate patches? Sure, will do. > > > target/linux/sunxi/config-4.4 | 15 ++++++++++++++- > > target/linux/sunxi/image/Makefile | 4 ++++ > > target/linux/sunxi/profiles/orangepi_mini.mk | 19 +++++++++++++++++++ [..] > > > +CONFIG_R8188EU=m > > > I have to slightly disagree here. The pcduino3 profile puts this into a > module (kmod-net-rtl8188eu), what was the reason for not following that? I think I simply misunderstood how this works. I wanted to use kmod-net-rtl8188eu but I thought that the only way to make sure it was built was to also set it =m in the kernel. I'll have a look at pcduino3 to understand how this should be done. [..] > > +# CONFIG_WILC1000_DRIVER is not set > > # CONFIG_WQ_POWER_EFFICIENT_DEFAULT is not set > > > Just nitpicking, can you add these as a missing symbol into > target/linux/generic/config-4.4 in the series? eheh, yeah that'd be the right place. [..] > > +define Profile/Orangepi_mini > > + NAME:=Orangepi_mini > > + PACKAGES:=\ > > + uboot-sunxi-Orangepi_mini kmod-ata-core kmod-ata-sunxi \ > > + kmod-rtc-sunxi kmod-mac80211 kmod-net-rtl8188eu > > +endef > > > Hmm. Can you please revisit the 8188 module then. :) > yeah - as said above, I wanted to use kmod-net-rtl8188eu but I haven't found the right way to make sure it got compiled. I'll fix this. Thank you ! Cheers, -- Antonio Quartulli
signature.asc
Description: Digital signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
