On 2/28/19 3:39 AM, Andreas Ziegler wrote:
Jeff Kletsky schrieb am 25.02.19 um 02:22:
On 2/24/19 4:21 PM, Andreas Ziegler wrote:
Hi Jeff,
thanks for your suggested change!
Although i agree with your change regarding USB GPIO, i don't with the
other part.
Using stock/vendor firmware, GPIO 12 is a green system/status LED and
GPIO 14 is a red wifi LED.
I just sent a patch to the list which fixes this in ar71xx target, maybe
you can update your patch for ath79, too.
see "[PATCH] ar71xx: GL.iNet AR300M family: correct LED definitions"
Regards
Andreas
Thank you for taking care of the ar71xx target.
I agree that the device has a red LED and have confirmed
with the manufacturer on this. Alas, I'm behind in
updating the patch.
Jeff
I took the liberty to send a Patch fixing this to the list.
After it is merged, i'll also try to rebase your patch for the
Lite-Version of the device if you don't mind.
Regards
Andreas
With three devices in pieces on my desk, that would be greatly appreciated.
No need for dueling patches!
The AR300M-Lite _does_ have different LED colors. Here's what I put
together this morning, built, and booted on my AR300M-Lite
target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts
========================================================
/dts-v1/;
#include "qca9531_glinet_gl-ar300m-nor.dts"
/ {
compatible = "glinet,gl-ar300m-lite", "qca,qca9531";
model = "GL.iNet GL-AR300M-Lite";
};
// GL-AR300M-Lite has different LED colors than the non-Lite version
&led_status {
label = "gl-ar300m-lite:red:status";
};
&led_lan {
label = "gl-ar300m-lite:green:lan";
};
&led_wlan {
label = "gl-ar300m-lite:green:wlan";
};
and the corresponding, referenced segment from
target/linux/ath79/dts/qca9531_glinet_gl-ar300m.dtsi
====================================================
leds {
compatible = "gpio-leds";
// Colors from non-Lite versions
led_status: status {
label = "gl-ar300m:green:status";
gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
};
led_lan: lan {
label = "gl-ar300m:green:lan";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
};
led_wlan: wlan {
label = "gl-ar300m:red:wlan";
gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
};
Jeff
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
