Em 02/07/2019 14:01, Paul Spooren escreveu:
some days ago I wrote this proposal[0] to split DEVICE_TITLE in
DEVICE_VENDOR, DEVICE_MODEL and DEVICE_VARIANT (holding revisions and
storage sizes if applicable).
I extended the image.mk to to use the newly introduced variables if
DEVICE_TITLE is empty, meaning it can be used as a drop in.
DEVICE_TITLE = $$(DEVICE_VENDOR) $$(DEVICE_MODEL)$$(if $$(value
DEVICE_VARIANT), $$(DEVICE_VARIANT))
This simplifies and unifies the DEVICE_TITLE creation and introduces the
possibility to search and sort devices based on vendor etc. A proof of
concept is available here[1].
In future PRs I'd rework existing targets (not only ath79 as in [0]) and
suggest developers adding new devices to use DEVICE_MODEL rather than
the full DEVICE_TILE in their patches.
I'd be happy to hear some comments!
If this changes the DEVICE_TITLE of something, it would be really
helpful to have a list of the affected DEVICE_TITLES (old and new)
posted somewhere.
Other than that minor detail, thanks for doing this!
--
Henrique de Moraes Holschuh
Analista de Projetos
Centro de Estudos e Pesquisas em Tecnologias de Redes e Operações
(Ceptro.br)
+55 11 5509-3537 R.:4023
INOC 22548*625
www.nic.br
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
