Hi, > diff --git a/target/linux/ath79/dts/ar1022_sitecom_wlr-7100.dts > b/target/linux/ath79/dts/ar1022_sitecom_wlr-7100.dts > new file mode 100644 > index 0000000000..8a70b597b0 > --- /dev/null > +++ b/target/linux/ath79/dts/ar1022_sitecom_wlr-7100.dts
You are using ar1022 here, but do not reference it in the compatible or provide a comment about it in the commit message. > + uenv: partition@30000 { You are not using the "uenv" label anywhere, so remove it. > +define Device/sitecom_wlr-7100 > + ATH_SOC := ar1022 > + DEVICE_VENDOR := Sitecom > + DEVICE_MODEL := WLR-7100 > + DEVICE_VARIANT := v1 002 What's the meaning of the "002"? If you have a variant "v1", you should include it in the device name, i.e. use sitecom_wlr-7100-v1 instead of sitecom_wlr-7100 etc. This will help users and developers when a v2 shows up. You can account for the alternate (marketing) name here with: DEVICE_ALT0_VENDOR := Sitecom DEVICE_ALT0_MODEL := X7 AC1200 > + DEVICE_PACKAGES := ath10k-firmware-qca988x kmod-ath10k kmod-usb2 Since 2018 OpenWrt uses -ct drivers by default. Please test and change to those. Best Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel