Well, address the issues we have agreed on in a v3. From my scanning of the open discussion points, the following was unresolved in some way: 1. Name prefix for LED labels In ar71xx, all devices use "d-link". In ath79, so far two devices use "d-link" and four devices use the device name. Since d-link looks like a vendor where heavy use of DTSI files is possible, I would use "d-link" as prefix for those.
2. Comments for ethX nodes in DTS files: I would remove the comments. It wouldn't be a big problem if you keep them for v3, though. 3. Partitioning: Remove the commented partitions and provide an extensive explanation in the commit message. Further discussion may be led based on a v3 patch then. Best Adrian > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Paul Fertser > Sent: Samstag, 7. Dezember 2019 22:11 > To: Petr Štetiar <yn...@true.cz> > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH v2] ath79: add D-Link DIR-615 E4 > > On Sat, Dec 07, 2019 at 09:58:26PM +0100, Petr Štetiar wrote: > > > I'll be happy to change the patch in any way that will get it accepted. > > > > Then just do the requested changes in v3, solved. > > I got an impression Adrian is not sure anymore he's requesting all the > changes we talked about, as I provided some reasonable counter-arguments > and that he is waiting for someone else to chime in. If you tell me I should > just do whatever Adrian says, ok, np. Do I get it right? > > -- > Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! > mailto:fercer...@gmail.com > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
