> > Consequently, having it set anyway is misleading, so this drops all > > cases. > > Well, I can tell you where it matters for devices. > > You'll have to look at this: > > <https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=include/target. > mk;h=9bd4c14936c1438df2be87e5697f5f5568699d2b;hb=HEAD#l54> > > |# Add device specific packages (here below to allow device type set > |from subtarget) DEFAULT_PACKAGES += > $(DEFAULT_PACKAGES.$(DEVICE_TYPE)) > > So, the MBL gets "DEFAULT_PACKAGES.nas" (block-mount fdisk lsblk > mdadm) over "DEFAULT_PACKAGES.router" (dnsmasq iptables ip6tables ppp > ppp-mod-pppoe firewall odhcpd-ipv6only odhcp6c kmod-ipt-offload) which > makes much more sense for other devices as well.
Hi Christian, that's exactly my point. Since this is target.mk as far as I can tell this selection does not work when DEVICE_TYPE is set within the device definition, but only when it's set in the (sub)target Makefile. As I understand it (and tested with make menuconfig), DEFAULT_PACKAGES is a per-target variable, and thus the DEVICE_TYPE from within the device definition will never be applied, and DEFAULT_PACKAGES.router will be used anyway for these devices. Or am I completely misled here? Best Adrian > > If you want to revert these changes and make this transparent, you'll > probably want to amend each device package list with the appropriate - > package (i.e -ppp -firewall -dnsmasq ...) all around. > > Cheers, > Christian > > > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
