Hello, On 03. 06. 20 14:53, Petr Štetiar wrote: > Pali Rohár <p...@kernel.org> [2020-06-03 14:48:23]: > >> What do you suggest to put into commit description of such small change >> where commit title already contains description of the whole change? > lspci output as in your other patch, simply something, otherwise it means > additional work for me I am looking into previous commits in iwinfo and there are not many commits which have the description, which you suggested at all. So, what has been changed? Other guys who have commit access it seems that they are not doing that and merging it as I think in the commit message is everything that you need. I think that your policy should be applied to all not just someone and should be followed by everyone. Just my two cents. For example, I was looking into these commits:
https://git.openwrt.org/?p=project/iwinfo.git;a=commit;h=eba5a204f776f49b9948b41e41c03560dbd307c8 https://git.openwrt.org/?p=project/iwinfo.git;a=commit;h=bb216982951698833bbdf4a88872e9b5ccd026a5 https://git.openwrt.org/?p=project/iwinfo.git;a=commit;h=e59f9253aa09a340d235dac074a10a4fe48b62fd and many others as well. Regards, Josef > > -- ynezz > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
signature.asc
Description: OpenPGP digital signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
