> 2.About "missing reg property". > Adrian Schmutzler wrote a letter to me about that, then I tested as he said, > it was ok. Here is the letter from him.
@Petr: The reg property is in the DTS files, while everything else is in the DTSI. It's also a case of DRY :-) > 5.About "Be DRY, use some common Device and just change IMAGE_SIZE and > DEVICE_VARIANT". > Here are three real type of boards by my hand, each has different flash, I > don't think it's good way to change board types by modifying the DTS file, > it's better to do that by selecting in menuconfig. @Robinson Wu: That's a misunderstanding from your side. What Petr meant was just to rearrange the definitions inside mt76x8.mk like this, so you define a common blueprint and then use that for the actual device definitions (note that MTK_SOC is not required anymore, as it's defined globally at the top of the file): +define Device/jotale_js76x8 + DEVICE_VENDOR := Jotale + DEVICE_MODEL := JS76x8 + DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci +endef +define Device/jotale_js76x8-16m + $(Device/jotale_js76x8) + IMAGE_SIZE := 16064k + DEVICE_VARIANT := 16M +endef +TARGET_DEVICES += jotale_js76x8-16m and so on for the other two devices. I just didn't request that as I personally prefer individual statement if it's "just" three lines for the common definition. Apart from that, please note these additional comments: 7. In master, gpio setup has changed, so you only have one &gpio now. So you will need to convert e.g. <&gpio1 5 GPIO_ACTIVE_LOW>; to <&gpio 37 GPIO_ACTIVE_LOW>; 8. pinctrl property rename: Convert + ralink,group = "p1led_an"; + ralink,function = "p1led_an"; to + groups = "p1led_an"; + ralink,function = "p1led_an"; Sorry for not having taken care earlier, but I can review only 80 % of your PR, and that's just not enough to merge it. Best Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
