Hi,

> +     DEVICE_VENDOR := Luma
> +     DEVICE_MODEL := Home (WRTQ-329ACN)

If you use WRTQ-329ACN as the primary name for OpenWrt here (as in device 
definition, compatible), I'd also put it first here and have the "Home" in 
brackets.
Apart from that, I'd make DEVICE_VENDOR/DEVICE_MODEL consistent with the DTS, 
so add the "Home" in brackets there, too.
 
> +     SOC := qcom-ipq4018
> +     DEVICE_DTS := qcom-ipq4018-wrtq-329acn

DEVICE_DTS can be dropped, it should be calculated from SOC and device name.

Best

Adrian 

Attachment: openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to