> On Sep 21, 2020, at 8:02 PM, Jacek Milewicz <jacekow...@jacekowski.org> wrote:
>
>
>
> On 22/09/2020 00:06, Ansuel Smith wrote:
>>>
>>>
>>> On 19/09/2020 15:06, Paul Oranje wrote:
>>>> See below, regards,
>>>> Paul
>>>>
>>>>
>>>>> Op 15 sep. 2020, om 21:56 heeft jacekow...@jacekowski.org het volgende
>>>>> geschreven:
>>>> The subject does not to comply with the rules for that, it should at least
>>>> start with the target, better would be:
>>>> ipq806x: fix tx-queue-size on NBG6817
>>>
>>> I was not aware of that.
>>>
>>>>> From: Jacek Milewicz <jacekow...@jacekowski.org>
>>>>>
>>>>> Fixes FS#3285 for NBG6817 only.
>>>> Why is that ?
>>>
>>> Because on IPQ806x SoC it is impossible to detect correct value,
>>> therefore it has to be set for each device in device tree (which is what
>>> this patch is doing).
>>>
>>> On most IPQ806x devices correct value has to be determined manually by
>>> trying few most common values and seeing what works (4k seems to be most
>>> common).
>>>
>> Can I ask you how you found out and how to check if a bad value is set?
>> Is this set by default on the OEM firmware? Any test or something?
>
> OEM firmware runs older kernel that does not check for tx-fifo-depth at all
> (https://patchwork.kernel.org/patch/11283121/ - this patch, dated December
> 2019 added the check). There is only few values that the driver will accept
> (256,512,1k,2k,4,8k,16k), so the easiest way to check is set it to highest
> (16k) and then try increasingly higher MTU to check at what point does it
> start dropping packets or crashing (and it seems like 4k is fairly common
> value on this SoC).
This all sounds like valuable, hard-won information that deserves to be
documented in the code.
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
