This will explain what is actually occuring on dd invocations.
Additionally remove comments for steps which are described by printed
statements anyway.

Signed-off-by: Tomasz Maciej Nowak <tmn...@gmail.com>
---
v1->v2
Additional remark in commit message

 target/linux/tegra/base-files/lib/upgrade/platform.sh | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/target/linux/tegra/base-files/lib/upgrade/platform.sh 
b/target/linux/tegra/base-files/lib/upgrade/platform.sh
index 715d1c1b8046..170bc11ba709 100644
--- a/target/linux/tegra/base-files/lib/upgrade/platform.sh
+++ b/target/linux/tegra/base-files/lib/upgrade/platform.sh
@@ -10,7 +10,7 @@ platform_check_image() {
 
        get_partitions "/dev/$diskdev" bootdisk
 
-       #extract the boot sector from the image
+       v "Extract boot sector from the image"
        get_image_dd "$1" of=/tmp/image.bs count=1 bs=512b
 
        get_partitions /tmp/image.bs image
@@ -50,7 +50,7 @@ platform_do_upgrade() {
        if [ "$UPGRADE_OPT_SAVE_PARTITIONS" = "1" ]; then
                get_partitions "/dev/$diskdev" bootdisk
 
-               #extract the boot sector from the image
+               v "Extract boot sector from the image"
                get_image_dd "$1" of=/tmp/image.bs count=1 bs=512b
 
                get_partitions /tmp/image.bs image
@@ -72,7 +72,7 @@ platform_do_upgrade() {
                return 0
        fi
 
-       #write uboot image
+       v "Writing bootloader to /dev/$diskdev"
        get_image_dd "$1" of="$diskdev" bs=512 skip=1 seek=1 count=4097 
conv=fsync,notrunc
        #iterate over each partition from the image and write it to the boot 
disk
        while read part start size; do
@@ -84,7 +84,6 @@ platform_do_upgrade() {
                fi
        done < /tmp/partmap.image
 
-       #copy partition uuid
        v "Writing new UUID to /dev/$diskdev..."
        get_image_dd "$1" of="/dev/$diskdev" bs=1 skip=440 count=4 seek=440 
conv=fsync
 }
-- 
2.29.2


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to