Hi Ilya,
On 2021-02-11 04:14, Ilya Lipnitskiy wrote: > The following commit removed _STAT_VER definitions from glibc: > https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0ab03e142500324a34087ce179ae78e > > That subsequently broke fakeroot: > https://bugs.archlinux.org/task/69572 > https://bugzilla.redhat.com/show_bug.cgi?id=1889862#c13 > https://forum.openwrt.org/t/unable-to-build-toolchain-fakeroot-fails-perhaps-others-after-it/87966 > > Make the patch based on Jan Pazdziora's suggestion from here: > https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/SMQ3RYXEYTVZH6PLQMKNB3NM4XLPMNZO/ > > Tested on my x86_64 Arch Linux machine, fakeroot unit tests pass. > > Signed-off-by: Ilya Lipnitskiy <ilya.lipnits...@gmail.com> If I'm not misreading the code, it seems to me that this patch might be incomplete. The old glibc version was carrying inline wrappers for stat, stat64, etc. Because binaries compiled against the old glibc version were only containing references to the wrapped internal functions and never the main functions directly, fakeroot seems to be handling only the __ prefixed internal functions. Defining _STAT_VER fixes the compile error and should work with binaries compiled against old glibc, but I wonder if this also works with newer binaries that now reference different functions. Did you explicitly test that? Thanks for looking into this, - Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
