On 2/24/21 1:49 AM, sotu...@gmail.com wrote:
From: Zheng Qian <sotu...@gmail.com>When luci unchecked the igmp snoop option for a bridge, it just delete the igmp_snooping key from the config file. So netifd can't change /sys/devices/virtual/net/br-lan/bridge/multicast_snooping from "1" to "0". This patch will set a default value to false for the bridge option to fix this bug. Signed-off-by: Zheng Qian <sotu...@gmail.com> --- bridge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bridge.c b/bridge.c index b70d626..464629c 100644 --- a/bridge.c +++ b/bridge.c @@ -875,6 +875,7 @@ bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)/* defaults */cfg->stp = false; + cfg->igmp_snoop = false; cfg->forward_delay = 2; cfg->robustness = 2; cfg->query_interval = 12500;
The default setting was removed in this change: https://git.openwrt.org/?p=project/netifd.git;a=commitdiff;h=52541140f8138e31958cdc3d7e42a4029fa6bbc9 - cfg->igmp_snoop = true; - cfg->multicast_querier = true; We should probably also set multicast_querier to false here. Hauke
OpenPGP_0x93DD20630910B515.asc
Description: application/pgp-keys
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
