On Mon, Mar 22, 2021 at 10:42:25AM +0000, Daniel Golle wrote: > On Mon, Mar 22, 2021 at 03:38:25PM +0530, Gaurav Pathak wrote: > > Hi John, > > > > I missed your message, seems like it didn't land in inbox or spam folder of > > my e-mail. > > > > > as it runs a custom modified version > > > of LXC > > > > > I assume that if this is a custom downstream version then the change > > is > > > not applicable for merge into upstream owrt. please explain what > > "custom > > > version" means. > > > > > John > > > > Actually, we don't use a custom version of lxc, we use the upstream stable > > lxc. > > The reason for this patch is that the hardcoded mount of /dev prevents our > > way of usage of openwrt in containers. > > In that case I believe the best is to revert the patch which applies a > Pantavisor-specific hack to detect if running inside a container and > switch to a method which works for all users of LXC equally (like it > is has already been done for Docker, see container.h in procd sources). > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
We tried to use the existing implementation that is in is_container() without any modification, but the key difference is that we use a container to run a full system container rather than just a "normal" app container, the current logic is correct when we use openwrt as an app container in our lxc based pantavisor, but it will do too much for the containers on our system that are suppose to run like the "main OS", like our pv-root plaforms. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
