On 24.03.2021 19:10, Adrian Schmutzler wrote:
The usual nitpicks below ...

Thanks for review!


+       [ "$magic" = "GT-AC5300" ] && {
+               echo "asus"
+               return
+       }
+
+       echo "unknown"
+}

One could modify this towards a case with default "unknown" (and drop the 
return again) ...

In the future this function will need to check for various variables so a 
single case (switch) won't be an option.

I've fixed all other pointed out places!

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to