Hi, On 05/10/2021 22:59, Sander Vanheule wrote:
One alternative could be to create some extra driver(s) in OpenWrt already, to get rid of setup.c (and prom.c at some later point) and work towards the upstream base for RTL838x/RTL839x. Anyone else with an opinion on this?
That's a good idea. But I think that one should also already take the work by brainslayer into account which adds a lot to the initial SoC configuration: https://github.com/BrainSlayer/pie/tree/pie-5.10-rtl9313/target/linux/realtek/files-5.10/arch/mips/rtl838x What we put in now should already anticipate the use of SMP (from 839x onwards), and for the 931x the GIC as the new Interrupt controller, large memory support and the GIC timer.
I also see that you're removing the _machine_halt function, while this isn't mentioned in the commit message. I had already removed _machine_halt in f4b687d1f053 ("realtek: use kernel defined halt"), but apparently it quietly got reintroduced in 8faffa00cb6b ("realtek: add support for the RTL9300 timer")Sh**, my bad.
Birger _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel