On Tue, Nov 16, 2021 at 7:07 PM Denis Kalashnikov <denis281...@gmail.com> wrote: > On MikroTik RB91x board series a reset key shares SoC gpio > line #15 with NAND ALE and NAND IO7. So we need a custom > gpio driver to manage this non-trivial connection schema. > Also rb91x-nand needs to have ability to disable a polling > of the key while it works with NAND, and we need to add > "cansleep" suffix to several gpiolib calls in gpio-latch. > > Signed-off-by: Denis Kalashnikov <denis281...@gmail.com>
Please find below one nonsignificant nitpick, in all other respects: Reviewed-by: Sergey Ryazanov <ryazanov....@gmail.com> > +struct gpio_rb91x_key { > + struct gpio_chip gc; > + struct mutex mutex; > + struct mutex poll_mutex; These mutexes are worth a line of documentation. I do not care too much, but if by some other reason you will submit v3, please consider to describe their purpose. > + int polling_disabled; > + struct gpio_desc *gpio; > +}; _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel