Please find a few comments related to a patch submission below. As for the airplane mode requirements, I would like to split that discussion into a separate thread and will send a separate reply.
On Sun, Dec 5, 2021 at 2:19 AM Henrik Ginstmark <hen...@ginstmark.se> wrote: > Den lör 4 dec. 2021 kl 23:19 skrev Sergey Ryazanov <ryazanov....@gmail.com>: >> On Sat, Dec 4, 2021 at 6:22 PM Henrik Ginstmark <hen...@ginstmark.se> wrote: >>> This command make it possible to query if the modem is in flight mode or >>> not. >>> >>> If you need to change your APN setting it should be done during flight mode >>> on. >> >> Just curious, is this true for any Qualcomm based mode or only for a >> specific model? > > When an LTE terminal is powered on it needs a valid APN to be able to > register to the > network. Some cellular operators allow an "empty" APN and then set a default > APN > to the terminal. > The most optimal way to power on an LTE terminal would be with flight mode on, > check that the correct APN is configured and then set flight mode off. > This is for all LTE terminals. > > I have a local uqmi version with commands for checking and modifying > the APN settings. > >> >>> To make it possible to automate change of APN setting --get-operating-mode >>> is >>> needed. >>> >>> Signed-off-by: Henrik Ginstmark <hen...@ginstmark.se> >> >> Your patch seems broken. Consider using git-format-patch and >> git-send-email to prepare and submit the patch, please. > > Sorry, I´m new to this. Do you know where I can find information about > git-format-patch and git-send-email? You can find more details about these utilities in the corresponding man pages. Please see man git-format-patch and man git-send-email You can find some more information about the patches submitting procedure in the project wiki: * https://openwrt.org/submitting-patches * https://openwrt.org/docs/guide-developer/working-with-git-email Also a good overview of the patch submitting can be found in the Linux kernel documentation: * https://www.kernel.org/doc/html/latest/process/submitting-patches.html A typical workflow for a uqmi patch submission will looks like this: $ git clone https://git.openwrt.org/project/uqmi.git $ cd uqmi $ git checkout -b new-feature-branch hack the code to introduce a new functionality with your favorite code editor $ git commit -s $ git format-patch HEAD^ $ git send-email --to=... --cc=... foo_bar.patch > What I understand is uqmi a sub-project > to openwrt, or? Yep. uqmi is the OpenWrt sub-project. > I´m still learning C. I will try to optimize the code in a better way. Your code looks well. Just needs some polishing :) -- Sergey _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel