On Thu, Jan 27, 2022 at 08:56:26PM -0800, Brian Norris wrote: > On Thu, Jan 27, 2022 at 5:34 AM Daniel Golle <dan...@makrotopia.org> wrote: > > Please see my comments inline below: > > > > On Sat, Jan 15, 2022 at 09:48:30PM -0800, Brian Norris wrote: > > > [...] > > > @@ -559,9 +585,8 @@ int main (int argc, char **argv) > > > uint32_t signature = 0x5452574F; /* 'OWRT' */ > > > guid_t guid = GUID_INIT( signature, 0x2211, 0x4433, \ > > > 0x55, 0x66, 0x77, 0x88, 0x99, 0xAA, 0xBB, 0x00); > > > - guid_t part_guid = GUID_PARTITION_BASIC_DATA; > > > > I think we should keep the default GUID, as there are uses for that > > other than Chrome OS which expect a valid part_guid. > > To be clear, the line you're highlighting was a dead assignment. In > the original code, it was overwritten without ever being used. > [...] > So, this might be a little confusing to read, but I don't believe it > breaks anything.
It's indeed just a bit confusing (and has been confusing also before you ever touched it). The default to GUID_PARTITION_BASIC_DATA is actually set in type_to_guid_and_name() function, so you are right, it's safe to drop it from the main() function as it was already dead code... I'll apply your patches as-is. Thank you! _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel