Hi Sander,

Op vrijdag 27 mei 2022 om 14:18:19 +02:00:00 schreef Sander Vanheule <san...@svanheule.net>:
Hi Stijn, Allesandro,

On Sat, 2022-05-21 at 22:59 +0200, Stijn Segers wrote:
 The DAP-2680 has a QCA9984 radio [1], but the commit adding support
 mistakenly adds the QCA99x0 firmware package. See forum topic [2].

 [1] https://wikidevi.wi-cat.ru/D-Link_DAP-2680_rev_A1
[2] https://forum.openwrt.org/t/missing-5ghz-radio-on-dlink-dap-2680/

This link doesn't work anymore, since the thread title has been (auto-)modified to "[SOLVED] ...".
The shortest working link is https://forum.openwrt.org/t/128025


 Fixes: 5b58710fad21 ("ath79: add support for D-Link DAP-2680 A1")

 Signed-off-by: Stijn Segers <f...@volatilesystems.org>
 Tested-by: Alessandro Fellin <af.registrazi...@gmail.com>
 ---

 v2: Fix typo (QCA998x -> QCA99x0)
 v3: Proper 'Fixes' tag (thanks svanheule)

  target/linux/ath79/image/generic.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/ath79/image/generic.mk b/target/linux/ath79/image/generic.mk
 index 4f36a08ff4..9729eb7555 100644
 --- a/target/linux/ath79/image/generic.mk
 +++ b/target/linux/ath79/image/generic.mk
 @@ -896,7 +896,7 @@ define Device/dlink_dap-2680-a1
    DEVICE_VENDOR := D-Link
    DEVICE_MODEL := DAP-2680
    DEVICE_VARIANT := A1
 -  DEVICE_PACKAGES := ath10k-firmware-qca99x0-ct kmod-ath10k-ct
 +  DEVICE_PACKAGES := ath10k-firmware-qca9984-ct kmod-ath10k-ct
    IMAGE_SIZE := 15232k
    DAP_SIGNATURE := wapac36_dkbs_dap2680
  endef

The caldata extraction places the calibration data in a QCA9888 directory [1], while for xiaomi,aiot-ac2350 (with QCA9988 radio) [2] this is placed in a QCA9984 directory. The ath10k- firmware-qca9984-ct package also puts the firmware files in the QCA9984 directory. Does the device
actually work properly in the 5GHz band with only this change?


Alessandro owns the device, hopefully he can comment on that.


If the caldata extraction needs to be modified too, this may be a good opportunity to convert to the nvmem-cells method. See for example commit 297bceeecf29 ("ath79: convert TP-Link Archer C7v1/2 Wifis
to nvmem-cells").

I'm afraid that's out of my league :-/

Cheers

Stijn


[1] Commit 5b58710fad21 ("ath79: add support for D-Link DAP-2680 A1")
[2] Commit 6c148116f778 ("ath79: add support for Xiaomi AIoT Router AC2350")

Best,
Sander



_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to