Hi Birger, On Sun, 2022-06-19 at 11:40 +0200, Birger Koblitz wrote: > Hi, > > On 19.06.22 10:56, Sander Vanheule wrote: > > > - h->cpu_tag[1] = h->cpu_tag[2] = 0; > > - if (prio >= 0) > > - h->cpu_tag[2] = BIT(13) | prio << 8; // Enable and set > > Priority Queue > > + h->cpu_tag[1] = 0; > > + /* Enable (AS_QID) and set Priority Queue (QID) */ > > + h->cpu_tag[2] = (BIT(5) | (prio & 0x1f)) << 8; > You are removing the possibility to let the SoC choose a Queue on its own > based on congestion, > if you always enable AS_QID. There was a reason that there were negative > Queue-ID values, which > denoted allowing the SoC to choose, i.e. AS_QID was not set.
I changed the code this way because prio was always positive, or made so by masking out the upper bits (rtl8380/rtl8390). The passed value (sk_buff::priority >> 1) positive (unsigned) too. There should be no change in behaviour with this patch. Currently preparing a second version (series) of these changes, which I will send shortly. Please let me know how this changes (hopefully improves) behaviour on the affected platforms, as I won't have time to test this in the next days. Best, Sander _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
