On 2022/11/29 22:04, Daniel Golle wrote:
On Tue, Nov 29, 2022 at 09:30:25PM +0900, INAGAKI Hiroshi wrote:
Hi Daniel,
thank you for your review.
On 2022/11/29 11:07, Daniel Golle wrote:
On Wed, Nov 23, 2022 at 12:24:09PM +0900, INAGAKI Hiroshi wrote:
...
@@ -972,10 +955,13 @@ define Device/iodata_wn-ax1167gr
$(Device/dsa-migration)
$(Device/uimage-lzma-loader)
IMAGE_SIZE := 15552k
- KERNEL_INITRAMFS := $$(KERNEL) | \
- iodata-factory 7864320 4 0x1055
$(KDIR)/tmp/$$(KERNEL_INITRAMFS_PREFIX)-factory.bin
DEVICE_VENDOR := I-O DATA
DEVICE_MODEL := WN-AX1167GR
+ifneq ($(CONFIG_TARGET_ROOTFS_INITRAMFS),)
+ ARTIFACTS := initramfs-factory.bin
+ ARTIFACT/initramfs-factory.bin := append-image initramfs-kernel.bin | \
Please use 'append-image-stage' so this will work also with the
ImageBuilder where initramfs is not being generated/present.
Oh, I didn't know it. Then, should I remove ifneq-endif switch for IB?
Yes, you should also drop the ifneq-endif for IB.
Okay, I'll drop ifneq-endif and send the next version.
BTW, when I compiled images of WN-AX1167GR only with
'append-image-stage', the following errors were printed and
compilation failed.
-------
cp
"/openwrt/user/git/musashino-build/openwrt/bin/targets/ramips/mt7621/openwrt-ramips-mt7621-iodata_wn-ax1167gr-initramfs-kernel.bin"
"/openwrt/user/git/musashino-build/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/tmp/openwrt-ramips-mt7621-iodata_wn-ax1167gr-initramfs-factory.bin.stripmeta"
fwtool -s /dev/null -t
"/openwrt/user/git/musashino-build/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/tmp/openwrt-ramips-mt7621-iodata_wn-ax1167gr-initramfs-factory.bin.stripmeta"
|| :
Data not found
fwtool -i /dev/null -t
"/openwrt/user/git/musashino-build/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/tmp/openwrt-ramips-mt7621-iodata_wn-ax1167gr-initramfs-factory.bin.stripmeta"
|| :
Data not found
dd
if="/openwrt/user/git/musashino-build/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/tmp/openwrt-ramips-mt7621-iodata_wn-ax1167gr-initramfs-factory.bin.stripmeta"
of="/openwrt/user/git/musashino-build/openwrt/staging_dir/target-mipsel_24kc_musl/image/ramips-mt7621-iodata_wn-ax1167gr-initramfs-kernel.bin"
dd: failed to open
'/openwrt/user/git/musashino-build/openwrt/staging_dir/target-mipsel_24kc_musl/image/ramips-mt7621-iodata_wn-ax1167gr-initramfs-kernel.bin':
No such file or directory
make[5]: *** [Makefile:230:
/openwrt/user/git/musashino-build/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/tmp/openwrt-ramips-mt7621-iodata_wn-ax1167gr-initramfs-factory.bin]
Error 1
make[5]: Leaving directory
'/openwrt/user/git/musashino-build/openwrt/target/linux/ramips/image'
make[4]: *** [Makefile:23: install] Error 2
make[4]: Leaving directory
'/openwrt/user/git/musashino-build/openwrt/target/linux/ramips'
make[3]: *** [Makefile:11: install] Error 2
make[3]: Leaving directory
'/openwrt/user/git/musashino-build/openwrt/target/linux'
time: target/linux/install#28.28#3.36#18.20
ERROR: target/linux failed to build.
make[2]: *** [target/Makefile:30: target/linux/install] Error 1
make[2]: Leaving directory '/openwrt/user/git/musashino-build/openwrt'
make[1]: *** [target/Makefile:24:
/openwrt/user/git/musashino-build/openwrt/staging_dir/target-mipsel_24kc_musl/stamp/.target_install]
Error 2
make[1]: Leaving directory '/openwrt/user/git/musashino-build/openwrt'
make: ***
[/openwrt/user/git/musashino-build/openwrt/include/toplevel.mk:231:
world] Error 2
-------
This seems to be caused by "image" directory in
staging_dir/target-mipsel_24kc_musl/ not existing, and when I created
that folder manually the build succeeded.
-------
user@hostmachine:/openwrt/user/git/musashino-build/openwrt$ mkdir
staging_dir/target-mipsel_24kc_musl/image
user@hostmachine:/openwrt/user/git/musashino-build/openwrt$ make -j8 V=s
...
(completed without errors)
-------
Should I add a patch to create "image" directory before copying?
+ check-size 7680k | senao-header -r 0x30a -p 0x1055 -t 4
+endif
DEVICE_PACKAGES := kmod-mt7603 kmod-mt76x2
endef
TARGET_DEVICES += iodata_wn-ax1167gr
--
2.36.1.windows.1
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
