Hi, Thank you for your quick review. On July 22, 2023, 4:36 p.m. UTC, Daniel Golle wrote:
>On Sat, Jul 22, 2023 at 10:52:02PM +0800, Shiji Yang wrote: >> From: Shiji Yang <[email protected]> >> >> This patch adds basic TX power control to the MT7620 and limits its >> maximum TX power. This can avoid the link speed decrease caused by >> chip overheating. > >Thanks a lot for your patch and analysis of the situation. >As you add code reading values from the EEPROM, we need to make sure >that it doesn't break other chips (Rt5xxx most likely, Rt3xxx could >also be affected). The easiest would be to create a new function >rt2800_config_alc_mt7620 which is called only for MT7620 while keeping >the original codepath for all other rt2800 radios (unless we are 100% >sure that we won't break things). > >> >> Signed-off-by: Shiji Yang <[email protected]> This rt2800_config_alc() function is only used by RT6352(AKA MT7620), so these changes are safe. I'll rename it to rt2800_config_alc_rt6352() on the V2 patch. ref: https://elixir.bootlin.com/linux/v6.4.3/A/ident/rt2800_config_alc _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
