Hi, that was my mistake - sorry!
Thanks for finding and fixing it :-)
I keep accidentally tapping the R key when jumping over words (E) for some
reason.
"Purging the r's" is something I do quite regularly.
But a 't'? :-D
Regarding the detection of such mistakes:
To retain alphabetical ordering, there have to be collateral line changes.
This can probably be alleviated by using to commits, one for adding the pattern
to the case expression and one for moving the existing patterns to restore
ordering.
I would argue that the brain is actually very good at spotting differences if
it's not occupied with "and this is the part where they've assigned the
interface roles".
It isn't much but I don't think automated tests or "more discipline" (coding or
reviewing) are appropriate or easier to implement reliably.
kind regards
On Sun, 15 Oct 2023 19:41:10 +0200
Bjørn Mork <bj...@mork.no> wrote:
> A typo snuck in with the addition of Cudy M1800, changing
> "nr7101" to "nt7101". The result is a default network config
> for NR7101 without the only ethernet interface on the NR7101,
> thereby soft bricking it.
>
> Fixes: f6d394e9f2fd ("ramips: add support for Cudy M1800")
> Signed-off-by: Bjørn Mork <bj...@mork.no>
> ---
> Ref
> https://forum.openwrt.org/t/zyxel-nr7101-not-responding-after-flashing-initramfs/174409
> and https://github.com/openwrt/openwrt/pull/13699
>
> This needs to be applied to 23.05 and master ASAP. It is already
> bricking devices.
>
> And it would be great if we could have some automated check
> to help us spot these kinds of unrelated and unexpected
> changes. I don't think the regular review process will ever
> be able to catch this, as that is mostly focues on the newly
> added device.
>
>
> Bjørn
>
> target/linux/ramips/mt7621/base-files/etc/board.d/02_network | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/target/linux/ramips/mt7621/base-files/etc/board.d/02_network
> b/target/linux/ramips/mt7621/base-files/etc/board.d/02_network index
> 67fe45f63360..b4c2c6dd68a8 100644 ---
> a/target/linux/ramips/mt7621/base-files/etc/board.d/02_network +++
> b/target/linux/ramips/mt7621/base-files/etc/board.d/02_network @@
> -95,7 +95,7 @@ ramips_setup_interfaces() ;; cudy,m1800|\
> yuncore,ax820|\
> - zyxel,nt7101)
> + zyxel,nr7101)
> ucidef_set_interfaces_lan_wan "lan" "wan"
> ;;
> gnubee,gb-pc1)
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
