Hi,
On Mon, 30 Oct 2023 at 23:11, Hauke Mehrtens <ha...@hauke-m.de> wrote:
>
> This fixes compilation with glibc.
>
> _FORTIFY_SOURCE only works with compiler optimizations activated.
> We have to deactivate it when we set -O0.
>
> This fixes the following error message with glibc:
> error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O)
> [-Werror=cpp]
>
> musl libc does not show an error message in this case, but has the same
> internal problems.
>
> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de>
> ---
> CMakeLists.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index a1ee0c1..78954c0 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -22,8 +22,9 @@ ADD_EXECUTABLE(urngd
> )
> TARGET_LINK_LIBRARIES(urngd ${ubox})
>
> -# jitter RNG must not be compiled with optimizations
> +# jitter RNG must not be compiled with optimizations, _FORTIFY_SOURCE needs
> optimizations
> SET_SOURCE_FILES_PROPERTIES(${JTEN_DIR}/jitterentropy-base.c PROPERTIES
> COMPILE_FLAGS -O0)
> +SET_SOURCE_FILES_PROPERTIES(${JTEN_DIR}/jitterentropy-base.c PROPERTIES
> COMPILE_FLAGS -U_FORTIFY_SOURCE)
You dropped the -O0 here, that needs to stay to disable optimizations.
Regards,
Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
