On Wed, 3 Jan 2024 at 10:20, Chuanhong Guo <gch981...@gmail.com> wrote: > > Hi! > > On Wed, Jan 3, 2024 at 10:14 AM <quic_shou...@quicinc.com> wrote: > > > > From: shoudil <quic_shou...@quicinc.com> > > > > Enable thumb flag to reduce package size, which help optimize the size > > of system image as well. > > > > Signed-off-by: shoudil <quic_shou...@quicinc.com> > > --- > > include/hardening.mk | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/hardening.mk b/include/hardening.mk > > index 6acd862f5c..8c59643866 100644 > > --- a/include/hardening.mk > > +++ b/include/hardening.mk > > "hardening.mk", as the file name implies, is specifically for hardening > options. > > > @@ -9,6 +9,10 @@ PKG_SSP ?= 1 > > PKG_FORTIFY_SOURCE ?= 1 > > PKG_RELRO ?= 1 > > > > +ifeq ($(ARCH),arm) > > + TARGET_CFLAGS += -mthumb > > +endif > > + > > This isn't a hardening option, so it doesn't belong here. > This should probably be part of package.mk instead.
Even then it should be a menuconfig option, not the default. Regards, Robert > -- > Regards, > Chuanhong Guo > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
