On 4/04/2024 19:42, INAGAKI Hiroshi wrote:
Hi stijn,
Hi Hiroshi,
I have some comments below.
Thanks for reviewing!

On 2024/04/04 23:28, st...@linux-ipv6.be wrote:
+
+    reboot@0 {
+        compatible = "edgecore,reboot";

Isn't this a "gpio-restart"? I can't find any informations about "edgecore,reboot".
Changing this to gpio-restart caused the device to reboot early during boot. After commenting out the gpio-restart node and testing with gpioset, it turns out it needs to be active-low.
+
+&switch0 {
+    ext_io: ext-io@e4 {
+        compatible = "realtek,rtl8390-eio", "syscon";

IIRC, a driver for "realtek,rtl8390-eio" is not provided on OpenWrt.
You need to mux sys-led pin as a gpio[1] and define this LED using gpio-leds.

[1]: https://github.com/openwrt/openwrt/blob/c7d83d4379fb2c08f22e7a4f2852aaf9b37c3790/target/linux/realtek/dts-5.15/rtl839x.dtsi#L289-L292
Done. The diag LED now exhibits the usual OpenWrt LED behaviour.

Thanks,
Stijn


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to