Hi Bjorn,

Op zondag 22 september 2024 om 18:29:50 +02:00:00 schreef Bjørn Mork <bj...@mork.no>:
Stijn Segers <f...@volatilesystems.org> writes:

 Fixes the following error in dmesg:

[ 7.703678] rtl83xx-switch switch@1b000000: Port node 24 misses phy-handle [ 7.711556] rtl83xx-switch switch@1b000000: Port node 26 misses phy-handle

rtl83xx_mdio_probe() is weird.  I guess the SoC phy polling makes that
necessary. But it should accept sfp ports without phys, because that's
what these are.  There are pnly 8 internal phys in this switch.

 @@ -59,6 +59,7 @@
                port@24 {
                        reg = <24>;
                        label = "lan9";
 +                      phy-handle = "<&phy24>";
                        phy-mode = "1000base-x";
                        managed = "in-band-status";
                        sfp = <&sfp0>;

This does not describe any hardware. It just works around a driver bug.

So what do you suggest? Leave it as-is? I can't recall seeing this error with 5.15.

Stijn



Bjørn



_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to