#19016: keepalive handler in ppp.sh is broken in BB 14.07
----------------------------+-----------------------------------
Reporter: anonymous | Owner: developers
Type: defect | Status: new
Priority: normal | Milestone: Barrier Breaker 14.07
Component: packages | Version: Barrier Breaker 14.07
Keywords: pptp keepalive |
----------------------------+-----------------------------------
/lib/netifd/proto/ppp.sh contains wrong handler for keepalive.
keepalive is a sting like '0 5'
the first number is number of fails, the second is the interval
This part is a wrong one
{{{
[ "${keepalive:-0}" -lt 1 ] && keepalive="" #<----here
[ -n "$mtu" ] || json_get_var mtu mtu
[ -n "$pppname" ] || pppname="${proto:-ppp}-$config"
local interval="${keepalive##*[, ]}"
[ "$interval" != "$keepalive" ] || interval=5
[ -n "$connect" ] || json_get_var connect connect
[ -n "$disconnect" ] || json_get_var disconnect disconnect
}}}
Example
{{{
keepalive='0 5'; [ "${keepalive:-0}" -lt 1 ] && keepalive=""
ash: 0 5: bad number
}}}
--
Ticket URL: <https://dev.openwrt.org/ticket/19016>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology
_______________________________________________
openwrt-tickets mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets
