Hello, World! On Wednesday, July 16, 2014 08:02:24 Joakim Hove wrote: > After reviewing: https://github.com/OPM/opm-core/pull/560 I though that > maybe the EclipseWriter stuff also should be moved to the parser? The > parser is already a quite fat and heavy 'parser' - and maybe renaming it to > something like EclipseInter / EclipseIO / ...; or alternatively we could > say that Eclipse is the baseline and call it Opm-IO?
opm-io is a good name in my opinion, but it implies that the "o" part is going
to be added. For that, I think that the current EclipseWriter class is too
entangled with the other opm-core classes, but maybe it's fit to be moved over
after another two or three refactorings/cleanups...
> When we really have
> plenty of time we could implement opm-core / opm-autodiff based on an
> abstract class Opm::ReservoirState - where Parser::EclipseState is derived
> from Opm::ReservoirState - but that is 2016 material I guess.
>
> Anyway - I hope the rename can be a topic of discussion for the autumn?
I concur. I also think that we should put the main focus of the next-after-
next release on redefining the scope of the individual modules and their
relation amongst each other. (E.g. it's currently hard to explain why opm-core
depends on opm-parser and not the other way around.)
cheers
Andreas
--
Notice: "String" and "Thread" are the same thing to non-computing
people.
— Programming.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Opm mailing list Opm@opm-project.org http://www.opm-project.org/mailman/listinfo/opm
