Thanks Luke. This is cool... In case people use the SPDX identifier, could you check for the following as well?
############################################################ ################## # Copyright (c) 2017 Donald Duck [dd...@warnerbros.com] and others. # # All rights reserved. This program and the accompanying materials # are made available under the terms of the Apache License, Version 2.0 # which accompanies this distribution, and is available at # SPDX-License-Identifier: Apache-2.0 ############################################################ ################## Also, is this meant to only check code or can we also check license in docs (e.g. Creative Commons 4.0)? Cheers, Ray On Thu, Apr 20, 2017 at 6:41 PM, Ash Young <a...@yunify.org> wrote: > Cool! I'm gonna check it out. Have a new version of PMD to also factor > into this. > > On Thu, Apr 20, 2017 at 9:43 AM, Luke Hinds <lhi...@redhat.com> wrote: > >> We have licence checking code staged for CI. >> >> 2017-04-20 15:27:43,197 - anteater.src.scan_tasks - INFO - Running >> Licence Check on: insecure-test-repo >> 2017-04-20 15:27:43,198 - anteater.src.scan_tasks - INFO - Licence Check >> passed for: /home/luke/ant_repos/insecure-python/path_traversal.py >> 2017-04-20 15:27:43,198 - anteater.src.scan_tasks - INFO - Licence Check >> passed for: /home/luke/ant_repos/insecure-python/shell_true.py >> 2017-04-20 15:27:43,198 - anteater.src.scan_tasks - ERROR - No License >> file within: /home/luke/ant_repos/insecure-python/tmp_path.py >> 2017-04-20 15:27:43,198 - anteater.src.scan_tasks - ERROR - No License >> file within: /home/luke/ant_repos/insecure-python/shell_true2.py >> >> It will search for the complete Apache 2.0 block, but will filter out >> text between: >> >> Copyright (c) 2017 <filter> and others >> >> ...As this is where an author adds unique fields, such as name, company, >> email. >> >> So this will pass for a python / bash file: >> >> ############################################################ >> ################## >> # Copyright (c) 2017 Donald Duck [dd...@warnerbros.com] and others. >> # >> # All rights reserved. This program and the accompanying materials >> # are made available under the terms of the Apache License, Version 2.0 >> # which accompanies this distribution, and is available at >> # http://www.apache.org/licenses/LICENSE-2.0 >> ############################################################ >> ################## >> >> So as long as someone uses the license format from the developers wiki or >> by means of Justin's license script [1], it will pass the gate. Any >> deviation from this, will get a -1 (when this is implemented at gate). >> >> I am planning on getting this rigged into CI during plugfest week. If >> anyone is interested or wants a demo, come by and say hello. >> >> [1] https://github.com/Justin-chi/Lab/blob/master/add_license.sh >> >> -- >> Luke Hinds | NFV Partner Engineering | Office of Technology | Red Hat >> e: lhi...@redhat.com | irc: lhinds @freenode | m: +44 77 45 63 98 84 | >> t: +44 12 52 36 2483 >> > >
_______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
