Hello Manuel,
The backward compatibily has been enforced for all env vars and you
shouldn't have seen any problem for
- CONST.__getattribute__('EXTERNAL_NETWORK')
- CONST.__getattribute__('OS_AUTH_URL')
- CONST.__getattribute__('OS_PASSWORD')
Then our change has also been merged https://gerrit.opnfv.org/gerrit/#/
c/52243/
The patch mentioned is about getting env var which is related to the
former config entry openstack_creds instead.
https://gerrit.opnfv.org/gerrit/#/c/52221/4
Here we could have enforced a backward compatility.
But it's hard to detect possible side effects when external programs
leverage on your internal config.
https://gerrit.opnfv.org/gerrit/#/c/51283/5/functest/ci/config_functest
.yaml
Thank you for the report. I updated your tree.
https://gerrit.opnfv.org/gerrit/#/c/52393/
Our 'readthedocs' documentation describes the Framework (external
interfaces).
We are currently defining additional interfaces for SDNVPN and SFC
which will be added to the documentation.
It will avoid the reuse of our internal objects.
Our API doc is built (per merge) by extracting docstrings and
automatically published to readthedocs.
No relevant docstring has been set in CONST.
Cédric
On mer., 2018-02-21 at 10:43 +0100, Manuel Buil wrote:
> Hey functest guys,
>
> We need again help with funcetst-sfc integration because there is
> something broken now related to the removal of the CONST module from
> your repo. This is our script:
>
> https://github.com/opnfv/sfc/blob/master/sfc/lib/openstack_utils.py
>
> In that script, we used to fetch several things with
> CONST.__getattribute__:
>
> os_env_file=CONST.__getattribute__('openstack_creds'))
> CONST.__getattribute__('EXTERNAL_NETWORK')
> CONST.__getattribute__('OS_AUTH_URL')
> CONST.__getattribute__('OS_PASSWORD')
>
> We tried to "s/CONST.__getattribute__/env.get" but
> env.get('openstack_creds') returns None.
>
> We were checking your patch:
>
> https://gerrit.opnfv.org/gerrit/#/c/52221/4
>
> And we realized that some of those parameters are now gone, so we
> wondered how should we do it now. We were checking your documented
> API:
>
> http://functest.readthedocs.io/en/latest/apidoc/functest.html
>
> However, we cannot see the functest.utils package there (CONST and
> env
> belong to that), so we are a bit lost about what needs to be changed
> on
> our side. We guess we must be using the functest API again in a
> wrong/not-supported-anymore way :(. Any link or any explanation which
> shows us how to do it properly will be appreciated.
>
> Thanks,
> Dimitris & Manuel
> _______________________________________________
> opnfv-tech-discuss mailing list
> opnfv-tech-discuss@lists.opnfv.org
> https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss_______________________________________________
opnfv-tech-discuss mailing list
opnfv-tech-discuss@lists.opnfv.org
https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
