Hi I reviewed PAXWEB-1119 and understood it. CMPN R7 Http Whiteboard spec (chapter 140) doesn't say anything about websockets. So I'm fine with forcing users to register WebSockets with "(websocket=true)" flag. If websocket endpoint can be (thank you very much JavaEE! - or maybe OSGi should add objectClass equivalent for annotations?) java.lang.Object, then websocket=true is acceptable.
I set fixVersion to 7.2.7 and 8.0.0. best regards Grzegorz Grzybek czw., 17 sty 2019 o 13:53 Grzegorz Grzybek <gr.grzy...@gmail.com> napisał(a): > Hello > > Achim - any reason why this was not merged? Something's missing? > > regards > Grzegorz Grzybek > > czw., 17 sty 2019 o 13:36 Jérémie Brébec <jeremie.bre...@gmail.com> > napisał(a): > >> I reopen (again) an old thread : Is there a plan to merge PAXWEB-1119 >> into master/7.2.x ? I have to cherry pick the patch/rebuild paxweb on every >> upgrade. >> >> >> Le mardi 8 août 2017 08:24:24 UTC+2, Achim Nierbeck a écrit : >>> >>> Hi, >>> >>> yes you're right using a non official osgi flag isn't good. >>> Will create another one, as we've done in the past for the Whiteboard >>> extension, when it wasn't in the spec. >>> >>> regards, Achim >>> >>> >>> 2017-08-07 20:26 GMT+02:00 Jérémie Brébec <jeremie...@gmail.com>: >>> >>>> Thanks, this tracker breaks the laziness of most of my whiteboard >>>> extenders (jaxrs, spring mvc @controller/@configuration, etc..). I didn't >>>> find however any mention on WebSocket in the future R7 spec, neither on the >>>> felix/equinox implementation. >>>> >>>> The only reference I found was in an implementation on Liferay, which >>>> use properties under "org.osgi.http.websocket.endpoint.*" (imho, not a good >>>> choice to use "org.osgi" prefixes..) >>>> >>>> >>>> >>>> Le lundi 7 août 2017 18:25:25 UTC+2, Achim Nierbeck a écrit : >>>>> >>>>> BTW, just created the following improvement: >>>>> https://ops4j1.jira.com/browse/PAXWEB-1119 >>>>> >>>>> 2017-08-07 18:22 GMT+02:00 Achim Nierbeck <bcan...@googlemail.com>: >>>>> >>>>>> Hi, >>>>>> >>>>>> the problem I see with this is, if one registers a WebSocket as >>>>>> Service, it usually doesn't need to be of a special Interface ... >>>>>> I can see that a property might help. Will think about this a bit >>>>>> more. >>>>>> >>>>>> Right now you can't disable it. >>>>>> >>>>>> regards, Achim >>>>>> >>>>>> >>>>>> 2017-08-07 14:00 GMT+02:00 Jérémie Brébec <jeremie...@gmail.com>: >>>>>> >>>>>>> Hello, >>>>>>> >>>>>>> In pax web 6, a WebSocketTracker is created. This tracker "track" >>>>>>> with a ServiceTracker every registration of services with the class >>>>>>> "Object". This tracker resolves every service through >>>>>>> bundleContext.getService(). >>>>>>> As a consequence, every component registered with "Object" are >>>>>>> resolved, breaking the Declaratives Services lazy properties. >>>>>>> >>>>>>> Is there a way to deactivate this tracker, or at least make it >>>>>>> activate only with the presence of a property ? This tracker is not >>>>>>> precise >>>>>>> enough, imho, to systematically calls getService on every references. >>>>>>> >>>>>>> Regard, >>>>>>> Jérémie >>>>>>> >>>>>>> -- >>>>>>> -- >>>>>>> ------------------ >>>>>>> OPS4J - http://www.ops4j.org - op...@googlegroups.com >>>>>>> >>>>>>> --- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "OPS4J" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to ops4j+un...@googlegroups.com. >>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Apache Member >>>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC >>>>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> >>>>>> Committer & Project Lead >>>>>> blog <http://notizblog.nierbeck.de/> >>>>>> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> >>>>>> >>>>>> Software Architect / Project Manager / Scrum Master >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Apache Member >>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC >>>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> >>>>> Committer & Project Lead >>>>> blog <http://notizblog.nierbeck.de/> >>>>> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> >>>>> >>>>> Software Architect / Project Manager / Scrum Master >>>>> >>>>> -- >>>> -- >>>> ------------------ >>>> OPS4J - http://www.ops4j.org - op...@googlegroups.com >>>> >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "OPS4J" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to ops4j+un...@googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> >>> Apache Member >>> Apache Karaf <http://karaf.apache.org/> Committer & PMC >>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer >>> & Project Lead >>> blog <http://notizblog.nierbeck.de/> >>> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> >>> >>> Software Architect / Project Manager / Scrum Master >>> >>> -- >> -- >> ------------------ >> OPS4J - http://www.ops4j.org - ops4j@googlegroups.com >> >> --- >> You received this message because you are subscribed to the Google Groups >> "OPS4J" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to ops4j+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- -- ------------------ OPS4J - http://www.ops4j.org - ops4j@googlegroups.com --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
