Hi Kang, On 2 Aug 2011, at 08:11, aero wrote:
> I need to patch some opsview code to enable non-ascii chahraters(especially > korean) in several columns of DB tables. > See the attached file, please. > I hope this is going to be default in the future. Thanks. However, we're not going to extend the UTF8 support in this manner. The best practise is to set utf8 support at the db level and let DBIx::Class pass it all the way through, so we've updated this jira to reflect: https://secure.opsera.com/jira/browse/OPS-595 If you have a patch that worked in this manner, I'd be happy to include. > And > In opsview-web codes, it seems that Opsview migrated from non-Moose to Moose > object system. > but the code doesn't use __PACKAGE__->meta->make_immutable; at the end of > each package file. > If you don't put it in the code, Object creation performance will degrade. > > <my test result> > *Object Creation > 11655.01/s Moose > 212765.96/s Moose Immutable > > I hope this would be fixed. Thanks - I wasn't aware of this. I've added a script to add meta->immutable under any modules that use Moose, and put in a test case to flag any problems here, so this should be overed in future too. Ton _______________________________________________ Opsview-users mailing list [email protected] http://lists.opsview.org/lists/listinfo/opsview-users
