On Fri, 15 Oct 2010 16:07:33 +0000 (UTC) [email protected] wrote: > Author: Nick Mathewson <[email protected]> > Date: Fri, 15 Oct 2010 11:21:33 -0400 > Subject: Remove "is this too slow?" XXXX comments for code not appearing in > profiles > Commit: 247ce5876a56cdbbd6a7b3f501476ff10f4bce5e > > --- > src/or/circuitbuild.c | 2 -- > src/or/networkstatus.c | 3 +-- > src/or/policies.c | 2 +- > src/or/routerlist.c | 7 ------- > 4 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c > index a4cdf81..9c7262a 100644 > --- a/src/or/circuitbuild.c > +++ b/src/or/circuitbuild.c > @@ -3032,8 +3032,6 @@ choose_good_entry_server(uint8_t purpose, > cpath_build_state_t *state) > nodelist_add_node_family(excluded, node); > } > if (firewall_is_fascist_or()) { > - /*XXXX This could slow things down a lot; use a smarter implementation */ > - /* exclude all ORs that listen on the wrong port, if anybody notices. */
The second comment line here should not have been removed.
> smartlist_t *nodes = nodelist_get_list();
> SMARTLIST_FOREACH(nodes, const node_t *,node, {
> if (!fascist_firewall_allows_node(node))
Robert Ransom
signature.asc
Description: PGP signature
