On Fri, 5 Jun 2009 19:44:45 -0400 Nick Mathewson <ni...@torproject.org>
wrote:
>On Fri, Jun 05, 2009 at 02:41:53AM -0500, Scott Bennett wrote:
>Thank you so much for the stack traces! I have found a bug that I
>think might have caused this. (It's a little hard to tell for sure,
>because a bunch of functions got inlined.) Can you try this patch
>(also uploaded to flyspray)?
>
>
>diff --git a/src/or/policies.c b/src/or/policies.c
>index cb914d1..d55e86c 100644
>--- a/src/or/policies.c
>+++ b/src/or/policies.c
>@@ -411,6 +411,7 @@ load_policy_from_option(config_line_t *config,
>smartlist_t **policy,
> memcpy(&newp, n, sizeof(newp));
> newp.prt_min = 1;
> newp.prt_max = 65535;
>+ newp.is_canonical = 0;
> c = addr_policy_get_canonical_entry(&newp);
> SMARTLIST_REPLACE_CURRENT(*policy, n, c);
> addr_policy_free(n);
>
With the caveat in mind that I inserted the extra line manually into
0.2.1.15-rc, rather than into the version that had been crashing, I think
it's probably safe to close this PR now. 0.2.1.15-rc has been up over a
day already, and I've sent it a SIGHUP on three occasions so far, including
one a few minutes ago just as another test. Each time it appears to have
responded appropriately.
Thanks very much, Nick, for fixing the problem so quickly. I am a bit
curious to know how the line in question came to be missing, but it's not
terribly important at this point. I'm very glad to have normal functionality
returned to tor.
Scott Bennett, Comm. ASMELG, CFIAG
**********************************************************************
* Internet: bennett at cs.niu.edu *
*--------------------------------------------------------------------*
* "A well regulated and disciplined militia, is at all times a good *
* objection to the introduction of that bane of all free governments *
* -- a standing army." *
* -- Gov. John Hancock, New York Journal, 28 January 1790 *
**********************************************************************
