On Ter, 2006-12-05 at 09:50 +0100, Jules Colding wrote: > On Mon, 2006-12-04 at 14:22 +0100, Jules Colding wrote: > > Please review and test this patch. I'm not entirely convinced that I > > haven't introduced a bad bug or two but at least it works(*) here. > > No responses yet, so it seems that my patch is of the usual flawless > quality ;-)
Heh :) In fact, the patch sounds really nice, a sign of ORBit2 maturing for TCP/IP connections (which is traditionally seldom tested). My only comment is that the changelog entry could use a bit more detail. You only mention changes in one function, but the patch changes 4 functions and even adds a new commandline option which deserves a mention in the changelog too. Cheers, -- Gustavo J. A. M. Carneiro <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> The universe is always one step beyond logic. _______________________________________________ orbit-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/orbit-list
