I see, I will adapt the patch accordingly. Best Regards, Congwu
From: Beat Forster [mailto:beat.fors...@synthesis.ch] Sent: Tuesday, March 09, 2010 3:28 PM To: Chen, Congwu Cc: Synthesis Subject: Fwd: Re: [os-libsynthesis] [PATCH] SAN 1.1 generation support: Moved utility code from engine to sdk Hello Chen, just one additional remark to stringutil/stringutils: "stringutil" has been created as engine independent version of stringutils for the use in SDK_textdb and other modules. So it might be worth to try inclusion of stringutil instead of stringutils (the same way as done e.g. in dbitem) instead of using stringutils. Either this works directly or probably with minor changes or extensions. I would prefer this solution as it it fits more the original concept behind. I don't think it's a good idea to move around modules and changing licenses only because things are not fully understood. Best Regards, Beat Date: Mon, 8 Mar 2010 17:27:06 +0100 To: "Chen, Congwu" <congwu.c...@intel.com> From: Beat Forster <beat.fors...@synthesis.ch> Subject: Re: [os-libsynthesis] [PATCH] SAN 1.1 generation support: Moved utility code from engine to sdk Cc: Synthesis <os-libsynthesis@synthesis.ch> Bcc: luz_i...@synthesis.ch X-Attachments: Hello Chen, there is one problem with your proposal: Our SDK is using stringutil.h/stringutil.cpp for standalone application, so you can't just remove them, because they are missing then for these projects. I see that it is a little bit confusing to have two files with nearly the same names, but short term I see no chance to switch, as there are engine dependencies which aren't available for modules outside which do not link to the engine. Also the SDK documentation is based on these filenames. SYSYNC_ENGINE makes the decision whether inside or outside the engine dbitem is an example how this decision is done: #ifndef SYSYNC_ENGINE #include "stringutil.h" // local implementation of CStr <=> Str conversions #include "timeutil.h" // local implementation for time routines #endif I have no problems if a header description will be added to these 4 files to tell for which part it will be needed. A mid or long term solution can be a merge of the two files, but for this all plugins (which aren't open source) must be adapted. Best Regards, Beat Hello, As we already discussed, we will move some utility code from the engine to SDK required by SAN 1.1 support. Below is the impacted files, please comment: --- diff --git a/src/sysync/lineartime.cpp b/src/sysync_SDK/Sources/lineartime.cpp index 2a03013..2a03013 100755 --- a/src/sysync/lineartime.cpp +++ b/src/sysync_SDK/Sources/lineartime.cpp diff --git a/src/sysync/lineartime.h b/src/sysync_SDK/Sources/lineartime.h index dcc2e0a..dcc2e0a 100755 --- a/src/sysync/lineartime.h +++ b/src/sysync_SDK/Sources/lineartime.h diff --git a/src/sysync_SDK/Sources/stringutil.cpp b/src/sysync_SDK/Sources/stringutil.cpp deleted file mode 100644 index b7a18e0..0000000 diff --git a/src/sysync_SDK/Sources/stringutil.h b/src/sysync_SDK/Sources/stringutil.h deleted file mode 100644 index 74dbc00..0000000 diff --git a/src/sysync/stringutils.cpp b/src/sysync_SDK/Sources/stringutils.cpp index a3660d6..a3660d6 100755 --- a/src/sysync/stringutils.cpp +++ b/src/sysync_SDK/Sources/stringutils.cpp diff --git a/src/sysync/stringutils.h b/src/sysync_SDK/Sources/stringutils.h index 22bc492..22bc492 100755 --- a/src/sysync/stringutils.h +++ b/src/sysync_SDK/Sources/stringutils.h diff --git a/src/sysync/syncexception.cpp b/src/sysync_SDK/Sources/syncexception.cpp index 49179d8..49179d8 100755 --- a/src/sysync/syncexception.cpp +++ b/src/sysync_SDK/Sources/syncexception.cpp diff --git a/src/sysync/syncexception.h b/src/sysync_SDK/Sources/syncexception.h index 58a6bd5..58a6bd5 100755 --- a/src/sysync/syncexception.h +++ b/src/sysync_SDK/Sources/syncexception.h diff --git a/src/sysync/sysync_utils.cpp b/src/sysync_SDK/Sources/sysync_utils.cpp index 9ba91b6..9ba91b6 100755 --- a/src/sysync/sysync_utils.cpp +++ b/src/sysync_SDK/Sources/sysync_utils.cpp diff --git a/src/sysync/sysync_utils.h b/src/sysync_SDK/Sources/sysync_utils.h index 2ba442a..2ba442a 100755 --- a/src/sysync/sysync_utils.h +++ b/src/sysync_SDK/Sources/sysync_utils.h Best Regards, Congwu _______________________________________________ os-libsynthesis mailing list os-libsynthesis@synthesis.ch http://lists.synthesis.ch/mailman/listinfo/os-libsynthesis -- ----------------------------------------------- Beat FORSTER Dipl. El. Ing. ETH Dipl. NDS ETHZ in Betriebswissenschaften Managing Partner beat.fors...@synthesis.ch Synthesis AG SyncML Server & Client Solutions Badenerstrasse 18, CH-8004 Zürich, Switzerland Tel (direct): +41 44 440 66 02 Fax: +41 44 440 66 04 email: i...@synthesis.ch web: http://www.synthesis.ch ----------------------------------------------- -- ----------------------------------------------- Beat FORSTER Dipl. El. Ing. ETH Dipl. NDS ETHZ in Betriebswissenschaften Managing Partner beat.fors...@synthesis.ch Synthesis AG SyncML Server & Client Solutions Badenerstrasse 18, CH-8004 Zürich, Switzerland Tel (direct): +41 44 440 66 02 Fax: +41 44 440 66 04 email: i...@synthesis.ch web: http://www.synthesis.ch -----------------------------------------------
_______________________________________________ os-libsynthesis mailing list os-libsynthesis@synthesis.ch http://lists.synthesis.ch/mailman/listinfo/os-libsynthesis
