Bugs item #845976, was opened at 2003-11-20 09:47 Message generated for change (Settings changed) made by dnl You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109368&aid=845976&group_id=9368
Category: Interface Group: 3.0 Status: Open Resolution: None Priority: 7 Submitted By: Jason Brechin (brechin) >Assigned to: David N. Lombard (dnl) Summary: Hitting Cancel on Pkg In/Un'er runs In/Un Initial Comment: I hit Cancel after selecting a pkg to be installed (well... it was still selected, cf. bug 845971). It then proceeded to ask whether I wanted to go into the Configurator and then proceeded to perform the installation. Not a showstopper, but should be documented. ---------------------------------------------------------------------- Comment By: Jeff Squyres (jsquyres) Date: 2003-11-25 11:11 Message: Logged In: YES user_id=11722 This is now a doc fix for 3.0. Do a real fix after 3.0. ---------------------------------------------------------------------- Comment By: John (muglerj) Date: 2003-11-20 14:21 Message: Logged In: YES user_id=505737 Yep, Terry's right about the atomic operation of the system. I think you should doc this and move on until we can plan out the stuff we need to do. One thing we could do is clear all should_be_installed/uninstalled bits everytime install_uninstall_package is run. Thats pretty quick and painless if you think it would help. ---------------------------------------------------------------------- Comment By: Terry Fleury (tfleury) Date: 2003-11-20 13:31 Message: Logged In: YES user_id=116599 This is a multi-faceted problem due to the way that install_uninstall_package and the Updater GUI were initially designed. With the Updater GUI, the information about whether to install or uninstall a package doesn't get written to oda until the user clicks on the "Execute" button. This is fundamentally different from the Selector where every click writes information to oda. I did this so the user could click "Cancel" and have nothing happen. (I wanted to go back to the Selector and add a "Cancel" button to allow for the same behavior but ran out of time.) My idea was that Cancel would bypass calling install_uninstall_package completely, but that's not what actually occurs. The install_unintall_package script checks the "should_be_installed/uninstalled" bits every time (regardless of whether Execute or Cancel was clicked), runs the appropriate scripts, and clears the bits ONLY IF the package was installed/uninstalled correctly. This was the way John designed it. So if there is ANY sort of problem, the bit does not get cleared and is still shown as "should be installed/uninstalled" in oda and the Updater. One thing that should be done is to have install_uninstall_package take no action after the user clicks on "Cancel". This would involve the Updater GUI returning a success/failure code that could be checked. Another thing is to make the install/uninstall package operation atomic. Right now, some of the steps for installing/uninstalling can get executed, but the process can fail due to a missing uninstall script (for example), which leaves the system in an undefined state, AND oda shows the package as "should_be_...". I'm not sure how to make the install/uninstall operation atomic, but I think it's the only way to resolve this issue. ---------------------------------------------------------------------- Comment By: Jason Brechin (brechin) Date: 2003-11-20 09:50 Message: Logged In: YES user_id=274641 More, FYI: If I go in and deselect it (thereby mirroring the current situation) and hit cancel, it still runs the install. However, if I deselect it and hit Execute, it exits. Pkg In/Un reports Notice: Nothing to do. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109368&aid=845976&group_id=9368 ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Oscar-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/oscar-devel
