I know you want to integrate system sanity check in install_prereqs since the beginning and as Thomas and I said before, we have nothing against that.
Do we need to vote to know what to do on that point? Le vendredi 29 septembre 2006 08:09, Erich Focht a écrit : > On Thursday 28 September 2006 19:17, Geoffroy Vallée wrote: > > Le jeudi 28 septembre 2006 12:57, Erich Focht a écrit : > > > IMO you should at least print some warning in the case that the check > > > was not actually done because the package is missing. I just checked, > > > you do print a warning, so... well... should I add > > > > I am already printing a warning, but FYI because the core team rejected > > the idea of warnings in the system-sanity mechanism, it is just a message > > to the user, the system itself is not notified (which is fine for me). > > I saw the warning, that's why I wrote "you do print a warning". Regarding > the core team decisions, well, that was a discussion, not a vote. With pro > and contra arguments. But enough about the past. In the last email I was > suggesting a workaround which changes a "sometimes or mostly useful" check > into an "allways useful" one. > > Current implementation: > > install_cluster: > ... > system sanity check > - ... > - ssh-check.pl > - if sshd not installed: continue and be happy > - if sshd installed: check that PermitRootLogin is set, fail if not > ... > install_prereqs > - ... > - install sshd if not installed yet (part of "base" prereq) > ... > > > As explained, this way ssh-check.pl will fail checking the setup of sshd in > case it was not installed. And this is the reason why I was arguing (long > time ago) against a system sanity check decoupled from the prereqs > installation. > > Solution proposal 1: > > install_cluster: > ... > system sanity check > - ... > ... > install_prereqs > - ... > - install sshd if not installed yet (part of "base" prereq) > - ssh-check.pl (called from within install_prereqs) > - if sshd not installed: FAIL! > - if sshd installed: check that PermitRootLogin is set, fail if not > ... > > > Solution proposal 2: (preferred because shorter) > > install_cluster: > ... > ... > install_prereqs > - ... > - install sshd if not installed yet (part of "base" prereq) > - system sanity check (called from within install_prereqs) > - ssh-check.pl > - if sshd not installed: FAIL! > - if sshd installed: check that PermitRootLogin is set, fail if > not ... > > > > Any opinions? > > Regards, > Erich -- Geoff ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Oscar-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oscar-devel
