Hi Juan, Sorry for taking a while to reivew your change. I've been juggling various tasks over the last weeks and only able to merge submissions in a bit of adhoc way - you submission was in my inbox awaiting a time when I had clear my desk enough to get back to clearly my submissions backlog.
I have just done the review, and also modified osgkeyboard (that will be using X11 on my Linux system) to report event types when I keep the key down and this confirmed the behaviour your changes add to osgQt. All looks OK so I've gone ahead and merged. Changes now checked into svn/trunk so will be part of the 3.1.8 dev release. Cheers, Robert. On 19 June 2013 18:40, Juan Manuel Alvarez <naici...@gmail.com> wrote: > Hi! I am resubmitting my first submission. I sent it some days ago and it > did not receive any response. If it is something wrong with the submission, > please tell me so I can correct it. Please forgive me for the repost! > > So here is the submission again: > > When handling keyboard events on osgQt, if a key is kept pressed, multiple > sequences of KEYDOWN -> KEYUP events are fired. > > This is because Qt auto repeats keyboard events, so multiple calls are made > to GLWidget::keyPressEvent and GLWidget::keyReleaseEvent by Qt, and > subsequently translated to OSG events. > > The way to solve this is ignoring key released auto repeated events (see > http://qt-project.org/doc/qt-4.8/qkeyevent.html#isAutoRepeat), so multiple > KEYDOWN events are fired, but only one KEYUP. > > I attach a modified osgQt/GraphicsWindowQt.cpp with this change. > > Thanks! > > _______________________________________________ > osg-submissions mailing list > osg-submissions@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list osg-submissions@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
