Hi Anish,

Looking at the fix I don't think this works in all cases, it only makes it less 
likely to
occur.

The check and the set are still done non-atomically, so another thread could be 
scheduled
inbetween and one update would be lost.

My preferred solution would be to use std::atomic with exchange for the 
modifiedCount, but
I don't know if that's available across all compilers that OSG supports.  It's 
been in
since C++11 though so I would hope it's safe to use.

Cheers,
/ulrich

On 19/10/17 07:31, Anish Thomas wrote:
> Hi,
> 
> I've attached the original and the fixed versions of the texture-handling 
> files based on the head of the 3.2 branch.
> 
> Thank you!
> 
> Cheers,
> Anish

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
osg-submissions mailing list
osg-submissions@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to