Hi Robert,
just built RC3 with g++ 4.6 and the number of warnings has indeed been
reduced significantly, for the remaining ones see below. By the way, the
information in my first post were not quite correct, I forgot to set
CMAKE_BUILD_TYPE=Release, so this is a default build.
Best regards
Stephan
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgPlugins/Inventor/ConvertFromInventor.cpp:
In member function ‘virtual SbBool
SoVRMLImageTextureOsg::readInstance(SoInput*, short unsigned int)’:
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgPlugins/Inventor/ConvertFromInventor.cpp:1264:16:
warning: variable ‘retval’ set but not used [-Wunused-but-set-variable]
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgPlugins/ac/Geode.cpp:
In member function ‘void ac3d::Geode::ProcessGeometry(std::ostream&,
unsigned int)’:
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgPlugins/ac/Geode.cpp:806:35:
warning: variable ‘fRep_s’ set but not used [-Wunused-but-set-variable]
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgPlugins/ac/Geode.cpp:806:43:
warning: variable ‘fRep_t’ set but not used [-Wunused-but-set-variable]
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgPlugins/ac/Geode.cpp:807:35:
warning: variable ‘fOffset_s’ set but not used [-Wunused-but-set-variable]
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgPlugins/ac/Geode.cpp:807:46:
warning: variable ‘fOffset_t’ set but not used [-Wunused-but-set-variable]
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgViewer/GraphicsWindowX11.cpp:
In member function ‘virtual void
osgViewer::GraphicsWindowX11::checkEvents()’:
/home/stephan/Dev/LibSources/OpenSceneGraph-3.0.0-rc3/src/osgViewer/GraphicsWindowX11.cpp:1181:10:
warning: variable ‘destroyWindowRequested’ set but not used
[-Wunused-but-set-variable]
On 22.06.2011 14:42, Robert Osfield wrote:
Hi Stephan,
On Wed, Jun 22, 2011 at 11:00 AM, Stephan Wenglorz
<stephan.maku...@gmx.net> wrote:
I agree, as you said these warnings seem to be no problem, just some
superfluous variables, so I would ignore them for now rather than risk to
break something so close to the release.
I've done a reivew of all the warnings and most are indeed benign
cases of variables being set and then never used. In a couple of
cases it suggest that return codes were being ignored when warnings
should have been emitted to I've added these. Most cases were just
places where a variable and it's setting could be safely removed so
I've done this and removing code that isn't used should be very low
risk.
Since the changes looked low risk I've checked them into both
svn/trunk and OSG-3.0 branch so fingers crossed the next release
candidate with be close to warning free under g++ 4.6.
Robert.
_______________________________________________
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
