Hi Konstantin,

Thanks for the full name.

I haven't decided how best to tackle this submission yet.  As is it would
cause a performance hit as Pjotr explained.  I'm open to suggestions of how
best to resolve this issue whilst addressing the bug your change sought to
address.

Cheers
Robert.



On 28 February 2015 at 23:34, Matveyev Konstantin <lalakos...@gmail.com>
wrote:

> Konstantin Matveyev
>
> On Nov 20, 2014, at 12:46 PM, Robert Osfield wrote:
>
> Hi KOS,
>
> I have just got to reviewing your proposed change to Animation.cpp.  What
> name would you like me to use when attributing this fix when I check it in?
>
> Cheers,
> Robert.
>
> On 27 August 2014 13:03, Konstantin <lalakos...@gmail.com> wrote:
>
>>
>>
>> ---------- Forwarded message ----------
>> From: Konstantin <lalakos...@gmail.com>
>> Date: 2014-08-26 18:27 GMT+04:00
>> Subject: Last update in the osgAnimation::Animation ONCE mode bug fix
>> To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org>,
>> osg-submissi...@lists.openscenegraph.org
>>
>>
>> Hello everybody!
>>
>>
>>
>>
>> *osgAnimation/Animation.cpp**bool Animation::update (double time, int
>> priority)*
>>
>>
>> *OpenSceneGraph 3.2.1*:
>>
>>     case ONCE:
>>         if (t > _originalDuration)
>>             return false;
>>
>>
>> *Should be:*
>>
>>     case ONCE:
>>         if (t > _originalDuration)
>>         {
>>
>>
>> *            for (ChannelList::const_iterator chan = _channels.begin();
>>                      chan != _channels.end(); ++chan)
>> (*chan)->update(_originalDuration, _weight, priority);*
>>
>>             return false;
>>         }
>>
>> *maybe :)*
>>
>> KOS
>>
>> _______________________________________________
>> osg-users mailing list
>> osg-users@lists.openscenegraph.org
>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>
>>
> _______________________________________________
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
>
>
> _______________________________________________
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
>
_______________________________________________
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to