Frederik Ramm wrote: > Hi, > > I have committed a change to trunk that, when dealing with 0.6 > files, also looks at the version of an object for comparison and sorting > (not only type and id). > > This was necessary in order to process replicate diffs which sometimes > contain the same object twice, causing the old implementation to > complain about change streams "not being sorted" (as "being sorted", for > Osmosis, means that every object has to be greater than the previous). > Which task was complaining? I had intended to create a new task which would take a (sorted) change stream with full changes and collapse them into a single change per entity. This new task would allow existing tasks such as --apply-change to continue to be used as is. > If this causes problems for anybody then another option would have been > to leave the sorting code unchanged and instead replace the "greater > than" requirement in the sorted stream validator with a "greater or > equal" requirement. > Again, where is the sorted stream validator complaining. A full history change stream may not make sense for all tasks so relaxing the change might be a problem. I haven't thought about all the implications of full history change streams. > Bye > Frederik > > PS: Can we remove those tests the failure of which can be safely > ignored? So that someone who checks out and builds Osmosis has a chance > to build it without tests failing, and only if you do "ant > --with-all-bells-and-whistles-and-exotic-features" do you get the > current "something always fails but don't bother" functionality? > Sounds good to me. Deciding which is critical and which isn't critical and implementing it in a relatively clean way is the tricky bit. I suppose splitting them into simple unit tests and "integration" tests requiring a database might be a start? Might be worth splitting the existing test source folder into two halves, unit and integration tests. Open to better ideas though.
_______________________________________________ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
