Hi Igor, On Mon, Sep 26, 2011 at 4:11 AM, Igor Podolskiy < igor.podols...@vwi-stuttgart.de> wrote:
> Hi @osmosis-dev, > > <snip> > You can view the proposed (and fairly straightforward) implementation of > the tasks at this GitHub branch: > > https://github.com/podolsir/**osmosis-trunk-mirror/tree/**bound-tasks<https://github.com/podolsir/osmosis-trunk-mirror/tree/bound-tasks> > > or as a diff: > > https://github.com/podolsir/**osmosis-trunk-mirror/compare/** > work-base...bound-tasks<https://github.com/podolsir/osmosis-trunk-mirror/compare/work-base...bound-tasks> > > There are also unit tests for the new bits, it builds, passes checkstyle > and so on. > > What do you think? Are there any objections to incorporating this into the > current trunk? Anything that I should fix before? > It looks good! The bound support is always messy to deal with, so anything to helps in that space is welcome. If I'm reading your diff correctly (I haven't tried applying it), it looks like you only add long and short versions of the task names. I always add "-0.6" version of the tasks as well to handle the future case when 0.7 comes along. These would be: - compute-bounding-box-0.6 - set-bounding-box-0.6 Cheers, Brett
_______________________________________________ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
