Ah, I thought you are asking to update documentation too. ----- Original Message ----- > From: "Nadav Har'El" <n...@scylladb.com> > To: "Justin Cinkelj" <justin.cink...@xlab.si> > Cc: "Amnon Heiman" <am...@scylladb.com>, "Osv Dev" <osv-dev@googlegroups.com> > Sent: Wednesday, February 1, 2017 10:43:38 PM > Subject: Re: [RFC v2 3/4] httpserver: return thread ID of the started app > > On Wed, Feb 1, 2017 at 7:02 PM, Justin Cinkelj <justin.cink...@xlab.si> > wrote: > > > > > > > > > Amnon, if we're changing the return value of the app/command REST API in > > > OSv from always returning a null string to returning a string with > > numbers > > > in it, are we supposed to modify some API description somewhere? > > > > Enough to mention that in modules/httpserver/api-doc/listings/app.json? > > > > I think so, but it seems the "command" command there already returns a > string, so I guess it doesn't matter if it's an empty string or the string > listing thread ids as you did, so I don't think we need to change anything > here (except the c_str() thing). >
-- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
