On Sun, Sep 3, 2017 at 10:26 AM, Nadav Har'El <n...@scylladb.com> wrote:
> > On Fri, Sep 1, 2017 at 7:08 PM, Waldek Kozaczuk <jwkozac...@gmail.com> > wrote: > >> I changed >> int sendfile(int out_fd, int in_fd, off_t *_offset, size_t count) >> to >> ssize_t sendfile(int out_fd, int in_fd, off_t *_offset, size_t count) >> >> and all works like a charm. >> > > Wow, thanks, great detective work. When you first noticed this bug I > thought it might be something serious with the TCP/IP code, not something > as simple as this :-) > > By the way, this is why I try very hard never to use "extern C" explicitly > in OSv's source files, and instead #include the right header file. That > would have helped verify that we don't have the wrong signature (if we did, > it wouldn't have C linkage and C code wouldn't find it). > Thanks, I committed your suggested change, plus the #include I suggested. I committed it under your name, I hope you don't mind :-) Thanks again, Nadav. -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
