There is no good way for me to review this patch (to confirm you didn't forget any of the packages while sorting them)... Why is this important or even useful to have the package names sorted?
-- Nadav Har'El n...@scylladb.com On Tue, Feb 13, 2018 at 7:07 PM, geraldo netto <geraldone...@gmail.com> wrote: > Signed-off-by: geraldo netto <geraldone...@gmail.com> > --- > scripts/setup.py | 143 ++++++++++++++++++++++++++++++ > ++++++++++++++----------- > 1 file changed, 114 insertions(+), 29 deletions(-) > > diff --git a/scripts/setup.py b/scripts/setup.py > index 41aa976..766454f 100755 > --- a/scripts/setup.py > +++ b/scripts/setup.py > @@ -25,13 +25,38 @@ standard_ec2_post_install = ['pip install awscli &&' > class Fedora(object): > name = 'Fedora' > install = 'yum -y install --allowerasing' > - packages = ['gcc-c++', 'gcc-c++-aarch64-linux-gnu', 'git', 'gdb', > 'qemu-img', > - 'qemu-system-x86', 'libvirt', 'maven', > - 'ant', 'autoconf', 'automake', 'boost-static', > 'genromfs', 'libtool', > - 'flex', 'bison', 'maven-shade-plugin', 'python-dpkt', > 'tcpdump', 'gdb', > - 'gnutls-utils', 'openssl', 'p11-kit', 'patch', 'wget', > - 'unzip', 'ncurses', 'ncurses-devel', 'libstdc++-static', > 'openssl-libs', > - 'libedit-devel', 'yaml-cpp-devel' > + packages = [ > + 'ant', > + 'autoconf', > + 'automake', > + 'bison', > + 'boost-static', > + 'flex', > + 'gcc-c++', > + 'gcc-c++-aarch64-linux-gnu', > + 'gdb', > + 'genromfs', > + 'git', > + 'gnutls-utils', > + 'libedit-devel', > + 'libstdc++-static', > + 'libtool', > + 'libvirt', > + 'maven', > + 'maven-shade-plugin', > + 'ncurses', > + 'ncurses-devel', > + 'openssl', > + 'openssl-libs', > + 'p11-kit', > + 'patch', > + 'python-dpkt', > + 'qemu-img', > + 'qemu-system-x86', > + 'tcpdump', > + 'unzip', > + 'wget', > + 'yaml-cpp-devel', > ] > ec2_packages = standard_ec2_packages > test_packages = ['openssl-devel'] > @@ -103,8 +128,7 @@ class Fedora(object): > versions = [Fedora_19, Fedora_20, Fedora_21, Fedora_22, Fedora_23, > Fedora_24, Fedora_25, Fedora_26, Fedora_27] > > class RHELbased(Fedora): > - name = ['Scientific Linux', 'NauLinux', 'CentOS Linux', > - 'Red Hat Enterprise Linux', 'Oracle Linux'] > + name = ['Scientific Linux', 'NauLinux', 'CentOS Linux', 'Red Hat > Enterprise Linux', 'Oracle Linux'] > > class RHELbased_70(object): > packages = [] > @@ -139,12 +163,32 @@ class RHELbased(Fedora): > class Debian(object): > name = 'debian' > install = 'apt-get -y install' > - packages = ['build-essential', 'libboost-all-dev', 'genromfs', > 'autoconf', > - 'libtool', 'openjdk-7-jdk', 'ant', 'maven', > - 'libmaven-shade-plugin-java', 'tcpdump', 'gdb', 'gawk', > - 'gnutls-bin', 'openssl', 'python-requests', 'python-dpkt', > - 'qemu-system-x86', 'qemu-utils', 'lib32stdc++-4.9-dev', > - 'p11-kit', 'libssl-dev', 'libedit-dev', 'libncurses5-dev'] > + packages = [ > + 'ant', > + 'autoconf', > + 'build-essential', > + 'gawk', > + 'gdb', > + 'genromfs', > + 'gnutls-bin', > + 'lib32stdc++-4.9-dev', > + 'libboost-all-dev', > + 'libedit-dev', > + 'libmaven-shade-plugin-java', > + 'libncurses5-dev', > + 'libssl-dev', > + 'libtool', > + 'maven', > + 'openjdk-7-jdk', > + 'openssl', > + 'p11-kit', > + 'python-dpkt', > + 'python-requests', > + 'qemu-system-x86', > + 'qemu-utils', > + 'tcpdump', > + ] > + > ec2_packages = standard_ec2_packages > test_packages = ['libssl-dev', 'zip'] > ec2_post_install = None > @@ -161,12 +205,33 @@ class Debian(object): > class Ubuntu(object): > name = 'Ubuntu' > install = 'apt-get -y install' > - packages = ['build-essential', 'libboost-all-dev', 'genromfs', > 'autoconf', > - 'libtool', 'ant', 'qemu-utils', 'maven', > - 'libmaven-shade-plugin-java', 'python-dpkt', 'tcpdump', > 'gdb', 'qemu-system-x86', > - 'gawk', 'gnutls-bin', 'openssl', 'python-requests', > 'p11-kit', 'g++-multilib', > - 'libssl-dev', 'libedit-dev', 'curl', 'libvirt-bin', > - 'libncurses5-dev', 'libyaml-cpp-dev', 'unzip' > + packages = [ > + 'ant', > + 'autoconf', > + 'build-essential', > + 'curl', > + 'g++-multilib', > + 'gawk', > + 'gdb', > + 'genromfs', > + 'gnutls-bin', > + 'libboost-all-dev', > + 'libedit-dev', > + 'libmaven-shade-plugin-java', > + 'libncurses5-dev', > + 'libssl-dev', > + 'libtool', > + 'libvirt-bin', > + 'libyaml-cpp-dev', > + 'maven', > + 'openssl', > + 'p11-kit', > + 'python-dpkt', > + 'python-requests', > + 'qemu-system-x86', > + 'qemu-utils', > + 'tcpdump', > + 'unzip', > ] > ec2_packages = standard_ec2_packages > test_packages = ['libssl-dev', 'zip'] > @@ -212,14 +277,34 @@ class Ubuntu(object): > class LinuxMint(object): > name = 'LinuxMint' > install = 'apt-get -y install' > - packages = ['build-essential', 'libboost-all-dev', 'genromfs', > 'autoconf', > - 'libtool', 'ant', 'maven', > - 'libmaven-shade-plugin-java', 'tcpdump', 'gdb', 'gawk', > - 'gnutls-bin', 'openssl', 'python-requests', 'python-dpkt', > - 'qemu-system-x86', 'qemu-utils', 'g++-multilib', > - 'curl', 'libvirt-bin', 'libyaml-cpp-dev', > 'unzip', > - 'p11-kit', 'libssl-dev', 'libedit-dev', 'libncurses5-dev' > - ] > + packages = [ > + 'ant', > + 'autoconf', > + 'build-essential', > + 'curl', > + 'g++-multilib', > + 'gawk', > + 'gdb', > + 'genromfs', > + 'gnutls-bin', > + 'libboost-all-dev', > + 'libedit-dev', > + 'libmaven-shade-plugin-java', > + 'libncurses5-dev', > + 'libssl-dev', > + 'libtool', > + 'libvirt-bin', > + 'libyaml-cpp-dev', > + 'maven', > + 'openssl', > + 'p11-kit', > + 'python-dpkt', > + 'python-requests', > + 'qemu-system-x86', > + 'qemu-utils', > + 'tcpdump', > + 'unzip', > + ] > ec2_packages = standard_ec2_packages > test_packages = ['libssl-dev', 'zip'] > ec2_post_install = None > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups > "OSv Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to osv-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
